Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restores ability to add existing works to existing collections via dashboard #1605

Merged
merged 1 commit into from
Aug 31, 2017
Merged

Restores ability to add existing works to existing collections via dashboard #1605

merged 1 commit into from
Aug 31, 2017

Conversation

mjgiarlo
Copy link
Member

Refs #1191

This is a workaround that restores this functionality. We suspect the bug itself is a regression in Rails or Turbolinks. See #1191 for more analysis. This patch is being put in place to allow the 2.0.0.beta1 release to ship.

@samvera/hyrax-code-reviewers

@mjgiarlo
Restores ability to add existing works to existing collections via da…
8227114 
…shboard

Refs #1191

This is a workaround that restores this functionality. We suspect the bug itself is a regression in Rails or Turbolinks. See #1191 for more analysis. This patch is being put in place to allow the 2.0.0.beta1 release to ship.
@mjgiarlo mjgiarlo added this to the 2.0.0 milestone Aug 31, 2017
@no-reply no-reply self-requested a review August 31, 2017 16:37
no-reply
no-reply approved these changes Aug 31, 2017
View reviewed changes
Copy link
Contributor

@no-reply no-reply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this forward.

We should have a discussion about whether a more complete fix is needed prior to a final 2.0.0 release. In the meanwhile, I think we should merge and unblock beta.

@mjgiarlo mjgiarlo merged commit 5852d1f into master Aug 31, 2017
@mjgiarlo mjgiarlo deleted the allow_works_to_be_added_to_collections_via_dashboard branch August 31, 2017 19:05
@elrayle
Copy link
Contributor

elrayle commented Sep 1, 2017

I just tried this at master with this PR and I still get the InvalidAuthenticityToken error.

My process:

  • pulled latest master
  • engine_cart:clean and engine_cart:generate
  • clean fedora/solr
  • generate default admin set
  • create 1 collection
  • create 1 work
  • Dashboard -> Works -> select all works -> Add to Collection -> select my existing collection -> Update Collection

Gets error: ActionController::InvalidAuthenticityToken

I was hoping this was going to work. So sad. :(

@mjgiarlo
Copy link
Member Author

mjgiarlo commented Sep 1, 2017

I did the following:

git checkout master
git pull
rm -rf Gemfile.lock .internal_test_app
bundle
rake engine_cart:generate
cd .internal_test_app
emacs config/role_map.yml
fcrepo_wrapper &
solr_wrapper &
rails hyrax:default_admin_set:create
rails s

Then I:

  • created 2 works
  • created 1 collection
  • Collection show -> Add Works -> Dashboard -> Works -> select all works -> Add to Collection -> select collection -> Update Collection (works OK!)
  • Dashboard -> Works -> select all works -> Add to Collection -> select collection -> Update Collection (broken!)

mjgiarlo added a commit that referenced this pull request Sep 1, 2017
@mjgiarlo
Disable turbolinks on links to my_works_path
d1b80fc 
Refs #1191

Follows #1605
@mjgiarlo mjgiarlo mentioned this pull request Sep 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@no-reply no-reply no-reply approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mjgiarlo @elrayle @no-reply